Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] #2099: Add WASM integration test based on Orillion use-case #2122

Merged
merged 23 commits into from
Apr 22, 2022
Merged

[feature] #2099: Add WASM integration test based on Orillion use-case #2122

merged 23 commits into from
Apr 22, 2022

Conversation

Arjentix
Copy link
Contributor

Description of the Change

  • Added Rust smartcontract which is builded to Web Assembly by a build script
  • Added integration test which uses the smartcontract
  • Fixed some bugs in wasm module
  • Added debug-wasm feature which provides tools for printing objects from smartcontract

Issue

Benefits

  • One more test-example for Orillion devs
  • First WASM integration test
  • Fixed and improved wasm module

Possible Drawbacks

Build script is running every time something in the main directory was changed. There no way to run it only for tests

@Arjentix Arjentix added iroha2-dev The re-implementation of a BFT hyperledger in RUST Tests labels Apr 19, 2022
mversic
mversic requested changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@mversic mversic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, just what was need

@Arjentix Arjentix force-pushed the wasm_orillion_test branch from 0133224 to 77bc8c0 Compare April 20, 2022 10:38
@mversic mversic self-requested a review April 20, 2022 10:39
mversic
mversic previously approved these changes Apr 20, 2022
View reviewed changes
mversic
mversic reviewed Apr 20, 2022
View reviewed changes
@Arjentix Arjentix force-pushed the wasm_orillion_test branch from 7c27332 to 5def2e2 Compare April 20, 2022 18:34
@Arjentix Arjentix force-pushed the wasm_orillion_test branch from e7edee3 to c9a126d Compare April 21, 2022 11:12
@Arjentix Arjentix requested a review from SamHSmith as a code owner April 21, 2022 11:12
Arjentix added 12 commits April 22, 2022 13:06
@Arjentix
Add smartcontract
75eaca8 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Add test wihtout wasm itself
7abd8a5 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Glue together test and smartcontract
1f0f6d8 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Add success checking in build script
cd2367a 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Bring back workspace section in wasm package
663025d 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Add dbg function when debug-wasm feature enabled
df78b99 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Fix decoding problem caused by roles
b39050b 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Add fmt running in build script
ef29ce9 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Add DebugUnwrapExt
e7a734e 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Add wasm runtime config into wsv config
dd4c861 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Make test finally work
d4837d9 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Fix nightly clippy warnings
9c7f39a 
Signed-off-by: Daniil Polyakov <[email protected]>
Arjentix added 10 commits April 22, 2022 13:06
@Arjentix
Fix infinite recursion when running cargo lints
985fba3 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Add nightly toolchain installing for ci image
8a97f34 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Revert "Add nightly toolchain installing for ci image"
60d0c54 
This reverts commit d997382.

Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Fixed remarks from @mversic
7f4fbfb 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Fix another remarks from @mversic
e1d7704 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Add rustup show execution to debug ci/cd
3018661 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Commented env clearing to debug ci/cd
c9de621 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Add env vars printing to debug ci/cd
94ce061 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Remove only RUST_RECURSION_COUNT env var
70daf55 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Fix some ci/cd and clippy problems
5677183 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix Arjentix force-pushed the wasm_orillion_test branch from c9a126d to 5677183 Compare April 22, 2022 10:15
@Arjentix
Remove roles feature usage
f7dd546 
Signed-off-by: Daniil Polyakov <[email protected]>
@mversic mversic requested review from mversic and s8sato April 22, 2022 11:02
@Arjentix Arjentix merged commit e10a3e8 into hyperledger-iroha:iroha2-dev Apr 22, 2022
@Arjentix Arjentix deleted the wasm_orillion_test branch April 22, 2022 19:07
mversic pushed a commit to mversic/iroha that referenced this pull request May 2, 2022
@Arjentix @mversic
[feature] hyperledger-iroha#2099: Add WASM integration test based on …
4d2a8f4 
…Orillion use-case (hyperledger-iroha#2122)

Signed-off-by: Daniil Polyakov <[email protected]>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 4, 2022
@Arjentix @appetrosyan
[feature] hyperledger-iroha#2099: Add WASM integration test based on …
8a7554c 
…Orillion use-case (hyperledger-iroha#2122)

Signed-off-by: Daniil Polyakov <[email protected]>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
@Arjentix @appetrosyan
[feature] hyperledger-iroha#2099: Add WASM integration test based on …
79d15a6 
…Orillion use-case (hyperledger-iroha#2122)

Signed-off-by: Daniil Polyakov <[email protected]>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
@Arjentix @appetrosyan
[feature] hyperledger-iroha#2099: Add WASM integration test based on …
2f56b56 
…Orillion use-case (hyperledger-iroha#2122)

Signed-off-by: Daniil Polyakov <[email protected]>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
@Arjentix @appetrosyan
[feature] hyperledger-iroha#2099: Add WASM integration test based on …
ad00930 
…Orillion use-case (hyperledger-iroha#2122)

Signed-off-by: Daniil Polyakov <[email protected]>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
@Arjentix @appetrosyan
[feature] hyperledger-iroha#2099: Add WASM integration test based on …
64a117e 
…Orillion use-case (hyperledger-iroha#2122)

Signed-off-by: Daniil Polyakov <[email protected]>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
@Arjentix @appetrosyan
[feature] hyperledger-iroha#2099: Add WASM integration test based on …
e427e2f 
…Orillion use-case (hyperledger-iroha#2122)

Signed-off-by: Daniil Polyakov <[email protected]>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
@Arjentix @appetrosyan
[feature] hyperledger-iroha#2099: Add WASM integration test based on …
7ecace9 
…Orillion use-case (hyperledger-iroha#2122)

Signed-off-by: Daniil Polyakov <[email protected]>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
@Arjentix @appetrosyan
[feature] hyperledger-iroha#2099: Add WASM integration test based on …
d32c492 
…Orillion use-case (hyperledger-iroha#2122)

Signed-off-by: Daniil Polyakov <[email protected]>
mversic pushed a commit to mversic/iroha that referenced this pull request May 13, 2022
@Arjentix @mversic
[feature] hyperledger-iroha#2099: Add WASM integration test based on …
655fef1 
…Orillion use-case (hyperledger-iroha#2122)

Signed-off-by: Daniil Polyakov <[email protected]>
mversic pushed a commit to mversic/iroha that referenced this pull request May 13, 2022
@Arjentix @mversic
[feature] hyperledger-iroha#2099: Add WASM integration test based on …
b18fd2f 
…Orillion use-case (hyperledger-iroha#2122)

Signed-off-by: Daniil Polyakov <[email protected]>
@s8sato s8sato mentioned this pull request Jul 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mversic mversic mversic approved these changes

@s8sato s8sato s8sato approved these changes

@appetrosyan appetrosyan Awaiting requested review from appetrosyan

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

Assignees

@mversic mversic

@s8sato s8sato

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Arjentix @appetrosyan @mversic @s8sato