Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.locale method should returns current locale #601

Closed
ghost opened this issue May 21, 2019 · 4 comments · Fixed by #602
Closed

.locale method should returns current locale #601

ghost opened this issue May 21, 2019 · 4 comments · Fixed by #602
Labels
🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt released

Comments

@ghost
Copy link

ghost commented May 21, 2019 •
edited by issuehunt-oss bot
Loading

Issuehunt badges

Describe the bug

dayjs.locale()

should returns en instead of null

Expected behavior
returns en

Information

  • Day.js Version v1.8.14
  • OS: Mac
  • Browser Chrome
  • Time zone: PST
IssueHunt Summary

iamkun iamkun has been rewarded.

Sponsors (Total: $100.00)

Tips
@iamkun
Copy link
Owner

iamkun commented May 21, 2019

Good point. Checking

@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 22, 2019
@IssueHuntBot
Copy link

@IssueHunt has funded $100.00 to this issue.

@iamkun iamkun mentioned this issue May 22, 2019
Merged
@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels May 29, 2019
@IssueHuntBot
Copy link

@iamkun has rewarded $90.00 to @iamkun. See it on IssueHunt

  • 💰 Total deposit: $100.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $10.00

@iamkun
Copy link
Owner

iamkun commented Jul 8, 2019

🎉 This issue has been resolved in version 1.8.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix dayjs.locale() returns current global locale iamkun/dayjs
2 participants
@iamkun @IssueHuntBot