Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enums in capital case, not all upper case #36

Closed
mcshaz opened this issue Jul 13, 2016 · 3 comments
Closed

Enums in capital case, not all upper case #36

mcshaz opened this issue Jul 13, 2016 · 3 comments
Labels

Comments

@mcshaz
Copy link
Contributor

mcshaz commented Jul 13, 2016

First - huge thank you and kudos for getting this project under active development once again!

Setting the properties for an event instance, for example as below:

myEvt.Transparency = TransparencyType.Opaque;
myEvt.Status = EventStatus.Confirmed;

results in a serialised string with the following text:
STATUS:Confirmed
TRANSP:Opaque

this does not validate, as the string should be
STATUS:CONFIRMED
TRANSP:OPAQUE

@rianjs rianjs added the bug label Jul 14, 2016
@rianjs
Copy link
Collaborator

rianjs commented Jul 14, 2016

Thanks for the bug report. You seem comfortable making code changes... do you want to tackle this one?

If I had to guess, I would guess it's an easy-ish fix. Probably something like calling a ToString on an enum's name instead of using a const string inside a TransparencyType class. (Admittedly, I haven't looked.)

@mcshaz
Copy link
Contributor Author

mcshaz commented Jul 15, 2016

happy to - looking at the AttendeeSerializer class in its current form, the staus is not currently being serialized. I believe you might be working on this as per issue #45. ideally I can uncomment the tests in the deserialize test groups checking that these are failing, fix and rerun, but given the current problems with serialization it seems worth postponing issues to do with letter case until serialization of the properties is occurring.

Finding my way to the attendeeSerializer class, I saw a handful of simple/minor optimisations which are included in a pull request.

This was referenced Jul 15, 2016
@mcshaz
Copy link
Contributor Author

mcshaz commented Jul 25, 2016

fixed d30880a

@mcshaz mcshaz closed this as completed Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants