Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail on Windows #2

Closed
anjackson opened this issue Nov 8, 2013 · 1 comment
Closed

Tests fail on Windows #2

anjackson opened this issue Nov 8, 2013 · 1 comment
Labels
bug
Milestone
1.1.5 Release

Comments

@anjackson
Copy link
Member

I should also note that some of the unit test fail on Windows.

Failed tests:
  testTrie1(org.archive.url.PublicSuffixesTest): expected:<...
  testTrie2(org.archive.url.PublicSuffixesTest): expected:<...
  testTrie3(org.archive.url.PublicSuffixesTest): expected:<...

Tests in error:
  testWrite(org.archive.format.gzip.GZIPMemberWriterTest): \tmp\tmp.gz (The system cannot find the path specified)
  testGetRecordIteratorStringBoolean(org.archive.util.binsearch.SortedTextFileTest): \tmp\test.tmp (The system cannot find the path specified)
  testHasNext(org.archive.util.iterator.SortedCompositeIteratorTest): \tmp\a (The system cannot find the path specified)

Tests run: 171, Failures: 3, Errors: 3, Skipped: 0

The errors are easily understandable. I'm unsure why PublicSuffixesTest is failing though.

May be partly due to some hard-coded reference to /tmp?
RogerMathisen referenced this issue in nlnwa/webarchive-commons Sep 23, 2014
@RogerMathisen
- Replaced direct references to "/tmp" with generic temporary directo…
f7cd67d 
…ry reference using File.createTempFile().

Fixes bug reported in iipc/webarchive-commons Issue #2.
@RogerMathisen
Copy link
Contributor

Fix suggested in #26

@johnerikhalse johnerikhalse added this to the 1.1.5 Release milestone Sep 30, 2014
@kris-sigur kris-sigur mentioned this issue Sep 30, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.1.5 Release
Development

No branches or pull requests
3 participants
@anjackson @johnerikhalse @RogerMathisen