Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issue with gradient continuity check #247

Open
mcencini opened this issue Feb 10, 2025 · 0 comments
Open

Potential issue with gradient continuity check #247

mcencini opened this issue Feb 10, 2025 · 0 comments

Comments

@mcencini
Copy link
Contributor

mcencini commented Feb 10, 2025

Hi all,
are those lines supposed to be

if ( abs(grad_to_check.stop[1]) > self.system.max_slew * self.system.grad_raster_time and abs(grad_to_check.stop[0] - duration) > 1e-7 ): raise RuntimeError("A gradient that doesn't end at zero needs to be aligned to the block boundary.")

instead of the current version (i.e., similar to the check at the beginning of the gradient)? Otherwise, check will pass for negative ending gradients regardless of the alignment to the block boundary.
Cheers,
Matteo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant