New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Trezor support #1

Open

jordaniza opened this issue Jun 19, 2023 · 1 comment

jordaniza commented Jun 19, 2023

Hey @ind-igo, thanks for this. I'd like to use it with my Trezor and happy to PR into the repo instead of forking.

Just reviewing the BatchScript.sol file and want to double check the implementation approach with you to confirm I'm not missing anything:

https://github.com/ind-igo/forge-safe/blob/main/src/BatchScript.sol#L68
Add hash of "trezor" as an option

https://github.com/ind-igo/forge-safe/blob/main/src/BatchScript.sol#L158
Add trezor to switch statement - I am assuming trezor supports the mnemonic index flag but I can't see documentation on it?

Cheers

Owner

ind-igo commented Jun 21, 2023

Hey @jordaniza,

Yes, I believe this is correct, although you will also have to add another if block at https://github.com/ind-igo/forge-safe/blob/main/src/BatchScript.sol#L202 to be able to pass in the proper trezor cli args to cast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment