Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcpkgManager should trigger installation #37

Closed
keynmol opened this issue Sep 3, 2022 · 1 comment · Fixed by #49
Closed

vcpkgManager should trigger installation #37

keynmol opened this issue Sep 3, 2022 · 1 comment · Fixed by #49
Labels
bug Something isn't working

Comments

@keynmol
Copy link
Contributor

keynmol commented Sep 3, 2022

Configurator does: https://github.com/indoorvivants/sbt-vcpkg/blob/main/sbt-plugin/src/main/scala/com/indoorvivants/vcpkg/sbt/VcpkgPlugin.scala#L52
@keynmol keynmol added the bug Something isn't working label Sep 3, 2022
@keynmol
Copy link
Contributor Author

keynmol commented Sep 11, 2022

To avoid introducing a circular dependency, vcpkgManager should lose most of its methods that deal with flags, and those should move to VcpkgConfigurator

@keynmol keynmol mentioned this issue Sep 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor tasks and logging, increase configurator interface indoorvivants/sn-vcpkg
1 participant
@keynmol