Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add inertia_location helper #491

Merged
merged 1 commit into from
Jan 17, 2023
Merged

add inertia_location helper #491

merged 1 commit into from
Jan 17, 2023

Conversation

RoduanKD
Copy link
Contributor

I was working on a SaaS project and I needed to redirect to a tenant domain/subdomain. I googled around and saw this issue. and I saw @reinink comment and didn't notice the word "Ruby" 😅, and that's when I discovered that this helper isn't available in the Laravel adapter.

I thought about writing a test but ended up knowing that it won't pass since the other-domain isn't configured anywhere.
HelperTests.php

    public function test_the_location_helper_function_returns_a_response_instance(): void
    {
        $this->assertInstanceOf(Response::class, inertia_location('http://other-domain.test/');
    }

@reinink reinink merged commit 6ff8659 into inertiajs:master Jan 17, 2023
@reinink
Copy link
Member

reinink commented Jan 17, 2023

Yup, sure, seems like a reasonable addition 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants