Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Reddit 2025.06 - Disable screenshot popup, Hide navigation buttons, Remove subreddit dialog Patch failed #2772

Closed
7 tasks done
30b0 opened this issue Feb 8, 2025 · 4 comments
Labels
Bug report Something isn't working

Comments

@30b0
Copy link

30b0 commented Feb 8, 2025

Type

Error while patching

Tools used

RVX Manager

Application

Reddit 2025.06.0
Patches v.5.4.1-dev.4

Bug description

  • Disable Screenshot Popup
  • Hide Navigation Buttons
  • Remove Subreddit Dialog

These Patches failed while Patching the newest Version 2025.06.0 with the RVX Manager.

Error logs

Disable screenshot popup failed: app.revanced.patcher.patch.PatchException: Failed to resolve screenshotTakenBannerFingerprint
	at app.revanced.util.fingerprint.LegacyFingerprintKt.getException(LegacyFingerprint.kt:24)
	at app.revanced.util.fingerprint.LegacyFingerprintKt.methodOrThrow(LegacyFingerprint.kt:64)
	at app.revanced.patches.reddit.layout.screenshotpopup.ScreenshotPopupPatchKt.screenshotPopupPatch$lambda$2$lambda$1(ScreenshotPopupPatch.kt:27)
	at app.revanced.patches.reddit.layout.screenshotpopup.ScreenshotPopupPatchKt.$r8$lambda$6P66SX-KqraKsnPfsrzQecQoVj0(Unknown Source:0)
	at app.revanced.patches.reddit.layout.screenshotpopup.ScreenshotPopupPatchKt$$ExternalSyntheticLambda0.invoke(Unknown Source:2)
	at app.revanced.patcher.patch.Patch.execute(SourceFile:71)
	at app.revanced.patcher.patch.BytecodePatch.execute$revanced_patcher(SourceFile:166)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(SourceFile:84)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend(SourceFile:109)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at kotlinx.coroutines.flow.SafeFlow.collectSafely(SourceFile:57)
	at kotlinx.coroutines.flow.AbstractFlow.collect(SourceFile:226)
	at app.revanced.manager.flutter.MainActivity$runPatcher$1$patcherResult$1$1.invokeSuspend(SourceFile:323)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(SourceFile:33)
	at kotlinx.coroutines.DispatchedTask.run(SourceFile:101)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(SourceFile:263)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(SourceFile:95)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(SourceFile:69)
	at kotlinx.coroutines.BuildersKt.runBlocking(SourceFile:1)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(SourceFile:47)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(SourceFile:1)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$34(SourceFile:317)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$Oku38Rh6VOg9CiulxEElyw3q4GI(SourceFile:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda0.run(SourceFile:0)
	at java.lang.Thread.run(Thread.java:1117)


Hide navigation buttons failed: app.revanced.patcher.patch.PatchException: Failed to resolve bottomNavScreenSetupBottomNavigationFingerprint
	at app.revanced.util.fingerprint.LegacyFingerprintKt.getException(LegacyFingerprint.kt:24)
	at app.revanced.util.fingerprint.LegacyFingerprintKt.methodOrThrow(LegacyFingerprint.kt:64)
	at app.revanced.patches.reddit.layout.navigation.NavigationButtonsPatchKt.navigationButtonsPatch$lambda$7$lambda$6(NavigationButtonsPatch.kt:37)
	at app.revanced.patches.reddit.layout.navigation.NavigationButtonsPatchKt.$r8$lambda$FyMiZ9EYq1fmgi4pf8HeyBXI3Zw(Unknown Source:0)
	at app.revanced.patches.reddit.layout.navigation.NavigationButtonsPatchKt$$ExternalSyntheticLambda0.invoke(Unknown Source:2)
	at app.revanced.patcher.patch.Patch.execute(SourceFile:71)
	at app.revanced.patcher.patch.BytecodePatch.execute$revanced_patcher(SourceFile:166)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(SourceFile:84)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend(SourceFile:109)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at kotlinx.coroutines.flow.SafeFlow.collectSafely(SourceFile:57)
	at kotlinx.coroutines.flow.AbstractFlow.collect(SourceFile:226)
	at app.revanced.manager.flutter.MainActivity$runPatcher$1$patcherResult$1$1.invokeSuspend(SourceFile:323)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(SourceFile:33)
	at kotlinx.coroutines.DispatchedTask.run(SourceFile:101)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(SourceFile:263)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(SourceFile:95)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(SourceFile:69)
	at kotlinx.coroutines.BuildersKt.runBlocking(SourceFile:1)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(SourceFile:47)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(SourceFile:1)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$34(SourceFile:317)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$Oku38Rh6VOg9CiulxEElyw3q4GI(SourceFile:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda0.run(SourceFile:0)
	at java.lang.Thread.run(Thread.java:1117)


Remove subreddit dialog failed: app.revanced.patcher.patch.PatchException: Failed to resolve redditAlertDialogsFingerprint
	at app.revanced.util.fingerprint.LegacyFingerprintKt.getException(LegacyFingerprint.kt:24)
	at app.revanced.util.fingerprint.LegacyFingerprintKt.methodOrThrow(LegacyFingerprint.kt:64)
	at app.revanced.patches.reddit.layout.subredditdialog.SubRedditDialogPatchKt.subRedditDialogPatch$lambda$7$lambda$6(SubRedditDialogPatch.kt:86)
	at app.revanced.patches.reddit.layout.subredditdialog.SubRedditDialogPatchKt.$r8$lambda$58F9r0gtWVsPXia7ypDQbvEpzEA(Unknown Source:0)
	at app.revanced.patches.reddit.layout.subredditdialog.SubRedditDialogPatchKt$$ExternalSyntheticLambda0.invoke(Unknown Source:2)
	at app.revanced.patcher.patch.Patch.execute(SourceFile:71)
	at app.revanced.patcher.patch.BytecodePatch.execute$revanced_patcher(SourceFile:166)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(SourceFile:84)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend(SourceFile:109)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at kotlinx.coroutines.flow.SafeFlow.collectSafely(SourceFile:57)
	at kotlinx.coroutines.flow.AbstractFlow.collect(SourceFile:226)
	at app.revanced.manager.flutter.MainActivity$runPatcher$1$patcherResult$1$1.invokeSuspend(SourceFile:323)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(SourceFile:33)
	at kotlinx.coroutines.DispatchedTask.run(SourceFile:101)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(SourceFile:263)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(SourceFile:95)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(SourceFile:69)
	at kotlinx.coroutines.BuildersKt.runBlocking(SourceFile:1)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(SourceFile:47)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(SourceFile:1)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$34(SourceFile:317)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$Oku38Rh6VOg9CiulxEElyw3q4GI(SourceFile:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda0.run(SourceFile:0)
	at java.lang.Thread.run(Thread.java:1117)

Solution

No response

Additional context

No response

Device Environment

OnePlus 9 Pro | Android 15 | CrDroid 11.1 | Magisk Root

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I did not use any settings marked as Experimental Flags.
  • I have patched the APK according to the documentation.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@30b0 30b0 added the Bug report Something isn't working label Feb 8, 2025
@johnnyw94

This comment has been minimized.

@AkshayKanathur

This comment has been minimized.

@johnnyw94

This comment has been minimized.

@inotia00
Copy link
Owner

inotia00 commented Feb 9, 2025

Reddit started obfuscating codes this year, so fingerprints that hadn't been broken for months began to break quite often.

(They seem to be refactoring the code)

Even if I fix the fingerprint for Reddit 2025.06.0, it's likely that the patch will break again within a few weeks.

For this reason, I will regulate Reddit's supported version to 2025.05.1.

Support for the new version will be discussed in a few months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants