This repository has been archived by the owner on Jun 11, 2022. It is now read-only.
Correctly report errors from wallet's load, save, delete log operations #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 5, 2018 19:23
Mirror the style used by other subcommand modules.
Add more variants to wallet::Error as appropriate.
Consistently report and handle errors of Wallet::load, Wallet::save, and Wallet::delete_log.
Correctly handle I/O operation failures in Wallets::load(). Also, don't panic on invalid UTF-8 in file names: it can happen. Apply the same behavior as for other bad directory entry cases.
The changes in commit 71638d4 over-eagerly made it a failible offence to miss the public key file. Revert that.
If there is a problem loading one wallet, we log a warning and continue.
|
This goes towards fixing #39. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed lots of
.unwrap()from file I/O operations in methods ofWalletandWallets, returning errors instead for graceful reporting.