Fix error in refund calculation #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- value of `fpEpsilon` was off by the precision factor of `FixedPoint` - formula for refund calculation with decay was parenthesized in a wrong way
change `REWARD` to `RUPD`, update references
| @@ -35,7 +35,7 @@ fpPrecision :: FixedPoint | |||
| fpPrecision = (10::FixedPoint)^(34::Integer) | |||
|
|
|||
| fpEpsilon :: FixedPoint | |||
| fpEpsilon = (10::FixedPoint)^(17::Integer) | |||
| fpEpsilon = (10::FixedPoint)^(17::Integer) / fpPrecision | |||
JaredCorduan
approved these changes
Aug 11, 2019
There was a problem hiding this comment.
Looks great @mgudemann! thank you for fixing up the reward calculation and also adding some examples! 🚜
kevinhammond
pushed a commit
that referenced
this pull request
Oct 28, 2019
…_calculation Fix error in refund calculation
nc6
pushed a commit
that referenced
this pull request
May 19, 2020
755: Document the address discrimination problem from cardano-sl (NetworkMagic) r=intricate a=intricate Closes #727. Co-authored-by: Luke Nadur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error in the refund calculation, effectively it used
(d + (1 - d)) *exp(x)instead of(d + (1 - d)*exp(x)). Also thefpEpsilonconstant was wrong, making all decay instantaneous.This also adds examples for different ways to use