Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Shelley ledger integration with NoUnexpectedThunks checks enabled #1558

Closed
edsko opened this issue Feb 3, 2020 · 0 comments · Fixed by #1928
Closed

Run Shelley ledger integration with NoUnexpectedThunks checks enabled #1558

edsko opened this issue Feb 3, 2020 · 0 comments · Fixed by #1928
Assignees
@mrBliss
Labels
consensus issues related to ouroboros-consensus
Milestone
S11 2020-04-23

Comments

@edsko
Copy link
Contributor

edsko commented Feb 3, 2020

Marking as high priority even for the testnet, because if memory usage just blows up, the testnet won't be very usable.
@edsko edsko mentioned this issue Feb 3, 2020
Closed
@mrBliss mrBliss added this to the S7 2020-02-27 milestone Feb 4, 2020
@mrBliss mrBliss added the consensus issues related to ouroboros-consensus label Feb 28, 2020
@mrBliss mrBliss modified the milestones: S7 2020-02-27, S8 2020-03-12 Feb 28, 2020
@mrBliss mrBliss modified the milestones: S8 2020-03-12, S9 2020-03-26 Mar 13, 2020
@mrBliss mrBliss self-assigned this Mar 16, 2020
This was referenced Mar 20, 2020
Merged
Merged
Merged
@mrBliss mrBliss modified the milestones: S9 2020-03-26, S10 2020-04-09 Mar 27, 2020
@mrBliss mrBliss mentioned this issue Apr 9, 2020
Merged
iohk-bors bot added a commit that referenced this issue Apr 16, 2020
@iohk-bors @mrBliss @coot
Merge #1928 #1962
635f38e 
1928: Fix thunks in Shelley r=mrBliss a=mrBliss

Fixes #1558.

1962: node to client api changes r=coot a=coot

Small changes to NodeToClient api and LocalStateQuery protocol type signatures.

Related to #1950

- Added null peers in NodeToNode module
- Add kinds to type signatures of LocalQueryProtocol


Co-authored-by: Thomas Winant <[email protected]>
Co-authored-by: Marcin Szamotulski <[email protected]>
iohk-bors bot added a commit that referenced this issue Apr 16, 2020
@iohk-bors @mrBliss
Merge #1928
56fa6f9 
1928: Fix thunks in Shelley r=mrBliss a=mrBliss

Fixes #1558.

Co-authored-by: Thomas Winant <[email protected]>
@iohk-bors iohk-bors bot closed this as completed in 807f86a Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrBliss mrBliss

Labels
consensus issues related to ouroboros-consensus
Projects
None yet
Milestone
S11 2020-04-23
Development

Successfully merging a pull request may close this issue.

Fix thunks in Shelley IntersectMBO/ouroboros-network
2 participants
@mrBliss @edsko