Perfermance improvements for sending. #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
approved these changes
Jan 9, 2020
Socket send use vectored IO internally, every chunk will end up in a |
coot
reviewed
Jan 9, 2020
karknu
force-pushed
the
karknu/server_perf
branch
from
224a32c to
43d5a60
Compare
Reduce the number of syscalls by grouping multiple CBOR messages from the same miniprotocol together. Order within a miniprotocol is still precerved and fairness between miniprotocol is still enforced.
Calling getSocketName and getSocketOption for every SDU proved too costly. Use a static max segment size instead. Corresponds to about 8 full sized packets.
karknu
force-pushed
the
karknu/server_perf
branch
from
43d5a60 to
2f37422
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 10, 2020
1434: Perfermance improvements for sending. r=karknu a=karknu Implements performance improvements discussed in #1420 . Co-authored-by: Karl Knutsson <[email protected]>
coot
pushed a commit
that referenced
this pull request
May 16, 2022
1434: Perfermance improvements for sending. r=karknu a=karknu Implements performance improvements discussed in #1420 . Co-authored-by: Karl Knutsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements performance improvements discussed in #1420 .