ChainDB.Iterator: fix EBB bug #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using the very simple `Test.Util.TestBlock` test block, which was easier to generate, but could not represent EBBs. Now by using the `Test.Storage.TestBlock` test block, we can test with EBBs.
In the past, `ImmDB.getPointAtTip` used to be more expensive (it had to read a block from disk to get its hash). That's why we had `itGetImmDBTip`, implemented using the in-memory chain fragment, in `IteratorEnv`. The ImmDB (and ImmutableDB) keeps the hash of the block at the tip in memory, so we can use `itImmDB` directly and no longer need `itGetImmDBTip`. While at it, add `getTipInfo`, which also includes `IsEBB`, and use that to inspect the tip of the `ImmDB`.
|
Many thanks to @nfrisby for providing such a detailed bug report! |
nfrisby
requested changes
Jan 18, 2020
ouroboros-consensus/src/Ouroboros/Storage/ChainDB/Impl/Iterator.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/Ouroboros/Storage/ChainDB/Impl/Iterator.hs
Outdated
Show resolved
Hide resolved
Closes #1435. See the comment for more information.
mrBliss
force-pushed
the
mrBliss/fix-1435
branch
from
e2dd054 to
652dac5
Compare
|
You're right. I have rewritten the logic and made all 6 cases explicit (in the tests too). There was indeed no fallback to the VolatileDB needed. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 21, 2020
1475: ChainDB.Iterator: fix EBB bug r=mrBliss a=mrBliss Closes #1435. See the comment for more information. Co-authored-by: Thomas Winant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1435.
See the comment for more information.