Revert "ImmutableDB: truncate blocks from the future" #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 81f2f1e. See #1773, we first have to open the ImmutableDB /with/ all blocks because we don't know yet in which slot we are. We need the ImmutableDB to obtain a ledger state which will tell us which slot we're in. Afterwards, we can truncate the future blocks from the ImmutableDB. This last step will be done by the ChainDB and will follow in a future PR.
edsko
approved these changes
Apr 6, 2020
|
bors merge |
iohk-bors
bot
deleted the
mrBliss/revert-immutabledb-truncate-future-blocks
branch
coot
added a commit
that referenced
this pull request
May 16, 2022
1908: Revert "ImmutableDB: truncate blocks from the future" r=mrBliss a=mrBliss This reverts commit 81f2f1e. See #1773, we first have to open the ImmutableDB /with/ all blocks because we don't know yet in which slot we are. We need the ImmutableDB to obtain a ledger state which will tell us which slot we're in. Afterwards, we can truncate the future blocks from the ImmutableDB. This last step will be done by the ChainDB and will follow in a future PR. 1909: Fix typos r=coot a=coot Co-authored-by: Thomas Winant <[email protected]> Co-authored-by: Marcin Szamotulski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 81f2f1e.
See IntersectMBO/ouroboros-consensus#702, we first have to open the ImmutableDB /with/ all blocks because we
don't know yet in which slot we are. We need the ImmutableDB to obtain a
ledger state which will tell us which slot we're in. Afterwards, we can
truncate the future blocks from the ImmutableDB. This last step will be done
by the ChainDB and will follow in a future PR.