Skip to content
This repository has been archived by the owner on Jun 11, 2022. It is now read-only.

Fix build error on rust 1.27 #314

Closed
wants to merge 1 commit into from

Conversation

yihuang
Copy link

@yihuang yihuang commented Nov 5, 2018

@NicolasDP
Copy link
Contributor

NicolasDP commented Nov 6, 2018

thanks for looking into it. Can you tell us more why you need this specific version of the rust compiler ?

My concern is that SystemTime::UNIX_EPOCH is a recent change and that it might deprecates the former way to get this value.

Also, there is a serious security concern regarding all compilers prior 1.29.1 and I can only recommend you update the compiler version you depend on.

@mzabaluev
Copy link
Contributor

From discussion on the library change, the issue was more about discoverability of the constant, and the old name is OK otherwise. In any case, it has to stay there for Rust 1.0 timeframe.

That said, we may prefer to only target new compiler versions in the code, and switch to the 2018 edition as the baseline when it gets released.

@yihuang
Copy link
Author

yihuang commented Nov 7, 2018

It doesn't have the problem with the recent version of rust, my version was too old.

@NicolasDP
Copy link
Contributor

Thanks @yihuang , I think we can close this PR then if it is just easy to fix with an update of the compiler.

@NicolasDP NicolasDP closed this Dec 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants