Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change x_x_than_single consistency checks from 4 variants to 3 #52

Closed
intarga opened this issue Nov 1, 2024 · 0 comments · Fixed by #55
Closed

Change x_x_than_single consistency checks from 4 variants to 3 #52

intarga opened this issue Nov 1, 2024 · 0 comments · Fixed by #55
Labels
tech debt internal/maintainability improvements

Comments

@intarga
Copy link
Owner

intarga commented Nov 1, 2024

There seem to really be 3 possible climate relationships here. Either the single value should be above all in the sequence, within the range of the sequence, or below all. In this sense there is some overlap in the meaning of min_greater_than_single and max_less_than_single. Perhaps these should be combined into one test called single_outside_sequence?

@intarga intarga added the tech debt internal/maintainability improvements label Nov 1, 2024
@intarga intarga linked a pull request Nov 21, 2024 that will close this issue
6 tasks
@Lun4m Lun4m closed this as completed in #55 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt internal/maintainability improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant