Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better behaviour in flatline_check_cache and monotonic_decrease_check_cache. #56

Open
intarga opened this issue Nov 26, 2024 · 0 comments

Comments

@intarga
Copy link
Owner

intarga commented Nov 26, 2024

In these checks, the flag they return is relevant to a whole sequence. We should really flag each value according to the flags returned by running the check on ALL relevant sequences that include it, with a defined precedence order between the flags. This is already done for monotonic_decrease_check_cache in #55, but should be done for flatline_check_cache too.

A concern this adds though, is now we need trailing values as well has leading values to QC data with these checks, which stops them being usable in fresh pipelines. I propose we add a variant of these cache checks that pads the data with trailing Nones, so that fresh checks can still Fail data that meets the condition with its predecessors, and flag as DataMissing otherwise, to eventually be overwritten by a periodic pipeline that does have the trailing points. This needs to be done for both monotonic_decrease_check_cache and flatline_check_cache.

@intarga intarga mentioned this issue Nov 26, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant