Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: .net test bug #4841

Open
terriko opened this issue Feb 21, 2025 · 1 comment · May be fixed by #4842
Open

fix: .net test bug #4841

terriko opened this issue Feb 21, 2025 · 1 comment · May be fixed by #4842
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@terriko
Copy link
Contributor

terriko commented Feb 21, 2025 

 FAILED test/test_scanner.py::TestScanner::test_version_in_package[http://security.ubuntu.com/ubuntu/pool/main/d/dotnet8/-dotnet-runtime-8.0_8.0.12-0ubuntu1~24.10.1_amd64.deb-.net-8.0.12-other_products188] - AssertionError: clang found in dotnet-runtime-8.0_8.0.12-0ubuntu1~24.10.1_amd64.deb. If that's expected, make sure to add clang to the expected list of other_products.
assert 'clang' not in {'.net', 'clang', 'system.net.http'}

Probably an easy fix, I think this happened because of the way in which I merged the clang and .net prs all in one day and didn't re-run tests for safety.
@terriko terriko added bug Something isn't working good first issue Good for newcomers labels Feb 21, 2025
@22f1001635
Copy link

Hi @terriko,

Since clang is being detected (as expected from your recent merges), I'll be fixing the test by adding clang to other_products for the .net package. I’ll verify and run tests to confirm the fix. Let me know if there’s more to consider!
PR coming soon🚀

22f1001635 added a commit to 22f1001635/cve-bin-tool that referenced this issue Feb 22, 2025
@22f1001635
fix: .net test bug intel#4841
ea13e39
@22f1001635 22f1001635 linked a pull request Feb 22, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: dotnet test bug 22f1001635/cve-bin-tool
2 participants
@terriko @22f1001635