Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

New perfevents plugin #38

Open
andrzej-k opened this issue Dec 22, 2016 · 5 comments
Open

New perfevents plugin #38

andrzej-k opened this issue Dec 22, 2016 · 5 comments

Comments

@andrzej-k
Copy link
Contributor

andrzej-k commented Dec 22, 2016

Currently this plugin collects only limited set of metrics and only for Linux cgroups.
To leverage ideas in following issues: #18, #19 and #25 to make this plugin more flexible I would suggest re-writing it in C++, to leverage this API. New plugin should also work from inside Docker container - any paths should not be hard-coded but rather configurable. Plugin should also support metrics per system, socket, core and thread in addition to cgroup. Metric set should be configurable, not only limited to HW events, however HW events should be exposed in phase 1 it we would need to phase the development.

@skonefal
Copy link

@andrzej-k You should add dynamic metrics to your list.

@skonefal
Copy link

Please capture the full capabilities of Perf:

  • Per cgroup measurement
  • Per PID measurement
  • Per core measurement
  • Per socket measurement

@skonefal
Copy link

Perf event plugin should support custom devices/events. Example:

sudo perf stat --log-fd 1 -c -a -e '{intel_cqm/event=0x03,name=total_bytes/}' -- sleep 1

For obtaining local memory bandwidth per core.

@IzabellaRaulin
Copy link
Contributor

IzabellaRaulin commented Jan 16, 2017

I would like to highlight how important for snap-users is exposing dynamic metrics by this plugin:
@dgarth wrote in #32:

: I need to create the cgroup before even loading the plugin to get the metrics.

That causes if there are no cgroups at the moment of loading the plugin, perfevents collector does not expose any metrics (even afterward some cgroups are available).

@skonefal
Copy link

Support for float metrics :)

Invalid metric value for intel_cqm/llc_occupancy/:docker/62167f2c9f0b62068c3e0d09ee3275190ae7e41230e9861e324621442bbda222, err=strconv.ParseUint: parsing 229376.00: invalid syntax _module=plugin-exec io=stderr plugin=perfevents

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants