From 77e4266142eb1165ccced29e271295131cc3d529 Mon Sep 17 00:00:00 2001 From: Colm Doyle Date: Tue, 12 Dec 2023 10:28:32 +0000 Subject: [PATCH 1/4] Remove tagId parameter from companies test --- test/integration/companies.test.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/test/integration/companies.test.ts b/test/integration/companies.test.ts index 24ab0b79..0be07f80 100644 --- a/test/integration/companies.test.ts +++ b/test/integration/companies.test.ts @@ -69,7 +69,6 @@ describe('Companies', () => { page: 1, perPage: 35, order: Order.DESC, - tagId: '7882526', }); assert.notEqual(response, undefined); From f735ec971c4582aa4d2436f205b17d920ba76be9 Mon Sep 17 00:00:00 2001 From: Colm Doyle Date: Tue, 12 Dec 2023 12:37:16 +0000 Subject: [PATCH 2/4] Fix admin filtering in conversations.test.ts --- test/integration/conversations.test.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/test/integration/conversations.test.ts b/test/integration/conversations.test.ts index 65769052..7954e926 100644 --- a/test/integration/conversations.test.ts +++ b/test/integration/conversations.test.ts @@ -28,9 +28,10 @@ describe('Conversations', () => { before(async () => { const admins = await client.admins.list(); - adminId = admins.admins[0].id; - anotherAdminId = admins.admins[1].id; - + const adminList = admins.admins.filter((admin) => admin.has_inbox_seat); + // Only admins with inbox seat can interact with conversations. + adminId = adminList[0].id; + anotherAdminId = adminList[1].id; user = await client.contacts.createUser({ externalId: randomString(), name: 'Baba Booey', @@ -174,7 +175,7 @@ describe('Conversations', () => { const response = await client.conversations.redactConversationPart({ conversationId: foundConversation.id, conversationPartId: - foundConversation.conversation_parts.conversation_parts[0].id, + foundConversation.conversation_parts.conversation_parts[2].id, type: RedactConversationPartType.CONVERSATION_PART, }); From 383daa22500967b7281d8da95c8e7a37231db2a1 Mon Sep 17 00:00:00 2001 From: Colm Doyle Date: Tue, 12 Dec 2023 12:42:22 +0000 Subject: [PATCH 3/4] Refactor adminId assignment in messages.test.ts --- test/integration/messages.test.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/integration/messages.test.ts b/test/integration/messages.test.ts index d4efef97..73dc71a2 100644 --- a/test/integration/messages.test.ts +++ b/test/integration/messages.test.ts @@ -13,8 +13,10 @@ describe('Messages', () => { }); before(async () => { - const adminList = await client.admins.list(); - adminId = adminList.admins[0].id; + const admins = await client.admins.list(); + const adminList = admins.admins.filter((admin) => admin.has_inbox_seat); + + adminId = adminList[0].id; const createdUser = await client.contacts.createUser({ externalId: randomString(), From 13fc53cbd1e9b165301384dcb6ca32794600621a Mon Sep 17 00:00:00 2001 From: Colm Doyle Date: Tue, 12 Dec 2023 14:00:25 +0000 Subject: [PATCH 4/4] Disable create and update tests for dataAttributes --- test/integration/dataAttributes.test.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/integration/dataAttributes.test.ts b/test/integration/dataAttributes.test.ts index d359a0c8..d0b055df 100644 --- a/test/integration/dataAttributes.test.ts +++ b/test/integration/dataAttributes.test.ts @@ -8,7 +8,9 @@ describe('Data Attributes', () => { const client = new Client({ tokenAuth: { token } }); - it('create', async () => { + xit('create', async () => { + // The workspace we test on has hit the CDA limit, so we can't create any more + // for now. We should reenable this test once we have a new workspace. const response = await client.dataAttributes.create({ name: `Bebech${randomInt(0, 999)},${randomInt( randomInt(0, 999) @@ -23,7 +25,7 @@ describe('Data Attributes', () => { assert.notEqual(response, undefined); }); - it('update', async () => { + xit('update', async () => { const response = await client.dataAttributes.update({ id: createdDataAttribute.id, archived: false,