-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance issues introduced by nested exposures #59
Labels
Comments
This clearly has to do with nested exposures. We need a different way to find nested exposures than the current regex mechanism. They need to be flagged with a boolean and not retrieved time-and-again. Please feel free to contribute, I also will take a look. There's a related discussion in #58. |
AMar4enko
added a commit
to AMar4enko/grape-entity
that referenced
this issue
Feb 28, 2014
AMar4enko
added a commit
to AMar4enko/grape-entity
that referenced
this issue
Feb 28, 2014
AMar4enko
added a commit
to AMar4enko/grape-entity
that referenced
this issue
Feb 28, 2014
AMar4enko
added a commit
to AMar4enko/grape-entity
that referenced
this issue
Feb 28, 2014
AMar4enko
added a commit
to AMar4enko/grape-entity
that referenced
this issue
Feb 28, 2014
AMar4enko
added a commit
to AMar4enko/grape-entity
that referenced
this issue
Feb 28, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
So for some reason, grape-entity has become really slow for me recently. I played a bit with the nested exposures code and if I disable them (my entities don't have them), performance increases dramatically, we're talking API response goes from 900ms to 50ms for 25 records.
Here's the stuff I disabled: https://github.com/jure/grape-entity/commit/a46c7d5019cfbc856eb5b51ea730a9e17272108a
I would love to explore these issues more thoroughly, perhaps someone can guide me in the right direction.
The text was updated successfully, but these errors were encountered: