Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is ["dom"] lib really needed? #497

Closed
svenefftinge opened this issue Mar 1, 2017 · 3 comments
Closed

Is ["dom"] lib really needed? #497

svenefftinge opened this issue Mar 1, 2017 · 3 comments

Comments

@svenefftinge
Copy link

In https://github.com/inversify/InversifyJS#installation

You say we need to add lib "dom", while inversifyJS should work with node.js. Is that lib really needed? If yes, why is it?

@lholznagel
Copy link
Contributor

Inversify also works in the browser and I think that needs dom.

@remojansen
Copy link
Member

I'm not 100% sure but I think it was required because it was needed for promises or weak map I can't remember but there was something that was needed :( if you remove it, do you get errors? Feel free to try to remove it from our docs and config https://github.com/inversify/InversifyJS/blob/master/tsconfig.json#L4 and send a PR the CI servers will let us know if it is really needed :)

remojansen added a commit that referenced this issue Mar 22, 2017
@remojansen
Copy link
Member

So I finally got some free time to check this out and "dom" is not required 👍

@remojansen remojansen mentioned this issue Mar 22, 2017
9 tasks
remojansen added a commit that referenced this issue Mar 22, 2017
* Implemments #505

* Added docs for #505

* Implements #497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants