remove ability to resize textareas #1067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On android, without this line you see 3 diagonal lines in the lower right hand side of textareas. This suggests to the app user that the textarea is resizeable. On mobile apps you probably don't want the user to be able to resize textareas so I suggest this edit.
|
Adding a class to disable resizing of the textarea sounds best. People expect textareas to be resizable by default, I'd think. |
|
Are you interested in opening a pull request for the class? Something like |
|
depends on how opinionated ionic should be here. I don't think a user should EVER be able to increase a text area. But adding a class and documenting this behaviour would work too. Perhaps ping more core devs? |
|
I think we'll go with adding a new class because having the resizer by default is something most would expect. IMO, noticing that you do not like the resizer and having it explicitly removed, is better than expecting the resizer to be there, but not sure why it's not showing or how to get it to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On android, without this line you see 3 diagonal lines in the lower right hand side of textareas. This suggests to the app user that the textarea is resizeable. On mobile apps you probably don't want the user to be able to resize textareas so I suggest this edit.