-
Notifications
You must be signed in to change notification settings - Fork 300
Getting CI green #713
Comments
@diasdavid So far it doesn't seem that I need #695, except if it fixes ipfs-inactive/interface-js-ipfs-core#227 (i haven't tried yet) |
With the outstanding PRs merged and these three reverted: CI is quite often green. It's still not reliable, but as different tests are failing I'd consider them environment issues. |
@diasdavid Everything from my side is merged now. The test runs are quite stable now. Now only the tests broken by the commits mentioned above need to be fixed. Who will fix those? The authors of those commits? Edit: This is what it looks like without those commits reverted https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fjs-ipfs-api/detail/get-ci-green/70/tests |
@vmx would you have the chance to fix those too? thanks! |
@diasdavid Not sure when, but I can have a look if it isn't fixed in the meantime. |
@vmx I went through it. the files.stat was failing because it was expecting features that haven't been released on go-ipfs. ALl good now :) |
Thanks David for fixing those! I'm looking forward to have js-ipfs-api green fingerscrossed. |
This is a meta issue to collect all the PRs to get the CI Green
The text was updated successfully, but these errors were encountered: