Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitswap/messagequeue: DontHaveTimeoutConfig is not exported #842

Closed
Wondertan opened this issue Feb 12, 2025 · 2 comments · Fixed by #846
Closed

bitswap/messagequeue: DontHaveTimeoutConfig is not exported #842

Wondertan opened this issue Feb 12, 2025 · 2 comments · Fixed by #846
Assignees
@gammazero
Labels
need/triage Needs initial labeling and prioritization

Comments

@Wondertan
Copy link
Member

Wondertan commented Feb 12, 2025 •
edited
Loading

#750 introduced DontHaveTimeoutConfig struct with respective WithDontHaveTimeoutConfig. However, the new type is inside the internal pkg, making the type unaccessible for users. Likely, this was missed while porting #703 which had an alias.

cc @gammazero
@Wondertan Wondertan added the need/triage Needs initial labeling and prioritization label Feb 12, 2025
@Wondertan Wondertan mentioned this issue Feb 12, 2025
Draft
@gammazero gammazero self-assigned this Feb 15, 2025
gammazero added a commit that referenced this issue Feb 15, 2025
@gammazero
expose DontHaveTimeoutConfig
b4a9681 
This was missed in an earlier PR, and the config needs to be exposed using a type alias as the type is defined in an internal package.

- Add `DontHaveConfigConfig` type alias in bitswap client
- Add `DefaultDontHaveConfigConfig` function to get struct populated with default values.

Closes #842
@gammazero gammazero mentioned this issue Feb 15, 2025
Merged
@gammazero
Copy link
Contributor

Thank's for catching this. Fixed in #846

@Wondertan
Copy link
Member Author

@gammazero, any chance this can be patched soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gammazero gammazero

Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expose DontHaveTimeoutConfig ipfs/boxo
2 participants
@gammazero @Wondertan