expose DontHaveTimeoutConfig #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed in an earlier PR, and the config needs to be exposed using a type alias as the type is defined in an internal package. - Add `DontHaveConfigConfig` type alias in bitswap client - Add `DefaultDontHaveConfigConfig` function to get struct populated with default values. Closes #842
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #846 +/- ##
==========================================
+ Coverage 60.37% 60.48% +0.11%
==========================================
Files 243 244 +1
Lines 31119 31144 +25
==========================================
+ Hits 18787 18839 +52
+ Misses 10648 10624 -24
+ Partials 1684 1681 -3
|
Wondertan
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed in an earlier PR, and the config needs to be exposed using a type alias as the type is defined in an internal package.
DontHaveConfigConfigtype alias in bitswap clientDefaultDontHaveConfigConfigfunction to get struct populated with default values.Closes #842