-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not test ETAG values #73
Comments
Yeah, I already changed the CAR ones in #56 to only check for its presence, but not the value itself. |
I was thinking about this and it's not just about To make them good tests, we have to first make a request and use the Summarising, I think there's a few things here:
I'm not sure if this is something we can do right now: use the values of one request for the next. cc @laurentsenta @galargh |
Not yet but it's something we've been thinking about for a while and waiting for when the actual need arises - it seems it just has. We've been playing around with this idea in #30. The PR itself is not longer relevant in its' current form but there are some parts of it that we'll salvage. |
Brought up by @lidel and @hacdias on Slack:
https://filecoinproject.slack.com/archives/C04M8232QRW/p1685573605787349?thread_ts=1685531506.240809&cid=C04M8232QRW
The text was updated successfully, but these errors were encountered: