New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for Query.ReturnSizes #58

Closed

MichaelMure opened this issue Nov 22, 2019 · 0 comments

Contributor

MichaelMure commented Nov 22, 2019

In ipfs/go-datastore#134 is added a new request field in queries: Query.ReturnSizes.

To honor this field, datastore implementations can either:

return the size of the entry in Entry.Size if Query.ReturnSizes is set, or -1 otherwise
consider that returning the size doesn't imply a performance cost and always return the size in Entry.Size

The text was updated successfully, but these errors were encountered:

MichaelMure mentioned this issue

query: deny ReturnsSizes and ReturnExpirations instead of returning wrong result #59

Merged

Stebalien closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment