Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated flags/options #93

Closed
Stebalien opened this issue Mar 29, 2018 · 3 comments · Fixed by #225
Closed

Deprecated flags/options #93

Stebalien opened this issue Mar 29, 2018 · 3 comments · Fixed by #225
Assignees
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Milestone

Comments

@Stebalien
Copy link
Member

It would be nice to support both deprecated and removed flags. Deprecated flags would be hidden (but still work) and "removed" flags would inform the user that the flag has been removed and why.

@kevina kevina added the kind/enhancement A net-new feature or improvement to an existing feature label Oct 31, 2018
@lidel
Copy link
Member

lidel commented Jan 27, 2022

Need to bump this – adding to maintenance board.

Context

We have a bunch of deprecated command families (object, tar) which are hidden from ipfs --help, but are still accessible + people see them as regular commands in docs which are generated from sources (https://docs.ipfs.io/reference/http/api/, created by generator in https://github.com/ipfs/ipfs-docs/tree/main/tools/http-api-docs).

Implementation

We should add the ability to programmatically indicate three types of commands:

  • deprecated
  • removed
  • experimental (for new stuff, that may get changed)

Having that, --help and generated docs would be augmented to indicate that:

  • Helptext would be prefixed with WARNING: EXPERIMENTAL or DEPRECATED
  • docs would have separate sections at the end for those types of commands, setting proper devexp expectations.

It could be as simple as adding three bool fields to Command struct, and wiring things up around that.

@schomatis would you be interested in adding this to your queue?
Not a high priority, but would make a big difference for users learning-by-reading-docs or --help when eventually implemented.

@schomatis
Copy link
Contributor

Sure, will take a look at this next week.

@lidel
Copy link
Member

lidel commented Mar 18, 2022

Repository owner moved this from 🔎 In Review to ✅ Done in IPFS Shipyard Team Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants