Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(IF-NEEDED) Transition the build logic to account for browsers that don't support Blocking-WebRequest. #1154

Closed
4 tasks
Tracked by #1152
whizzzkid opened this issue Feb 15, 2023 · 3 comments
Assignees
Labels
area/chromium Issues related to Chromium-based browsers area/firefox Issues related to Mozilla Firefox area/MV3 Issues related to Manifest V3 version effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important P0 Critical: Tackled by core team ASAP status/blocked Unable to be worked further until needs are met topic/ci Continuous integration

Comments

@whizzzkid
Copy link
Contributor

whizzzkid commented Feb 15, 2023

Parent Issue: #1152
Blocked By: #1153

This only applies if the spike(#1153) fails.

ETA: 2023-03-30

Tasks

Preview Give feedback
@whizzzkid whizzzkid added status/blocked Unable to be worked further until needs are met exp/expert Having worked on the specific codebase is important P0 Critical: Tackled by core team ASAP area/firefox Issues related to Mozilla Firefox area/chromium Issues related to Chromium-based browsers effort/days Estimated to take multiple days, but less than a week topic/ci Continuous integration area/MV3 Issues related to Manifest V3 version labels Feb 15, 2023
@github-project-automation github-project-automation bot moved this to Needs Grooming in IPFS-GUI (PL EngRes) Feb 15, 2023
@SgtPooki
Copy link
Member

The initial tasks in this issue should be fairly trivial given webpack and the existing build logic.

@SgtPooki SgtPooki moved this from Needs Grooming to Needs Prep Work / Blocked in IPFS-GUI (PL EngRes) Feb 15, 2023
@lidel
Copy link
Member

lidel commented Feb 16, 2023

Before you sink too much time into this, double-check if we need to have a separate webpack build, and not just different Manifest for Firefox and Chromium (which we already have).

Afaik as long manifest if ok, you can do detection at runtime, like we do in https://github.com/ipfs/ipfs-companion/blob/main/add-on/src/lib/runtime-checks.js

Digression: In the past, every time we did anything fancy in webpack in companion it was a maintenance hell (libraries breaking APIs after few months/years, entire webpack deprecating apis and forcing ecosystem to migrate, just bunch of useless work to keep functionality going AND have up-to-date dependencies).

@SgtPooki SgtPooki changed the title Transition the build logic to account for browsers that don't support Blocking-WebRequest. (IF-NEEDED) Transition the build logic to account for browsers that don't support Blocking-WebRequest. Mar 13, 2023
@whizzzkid
Copy link
Contributor Author

Won't be needed. Closing for now.

@github-project-automation github-project-automation bot moved this from Needs Prep Work / Blocked to Done in IPFS-GUI (PL EngRes) Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chromium Issues related to Chromium-based browsers area/firefox Issues related to Mozilla Firefox area/MV3 Issues related to Manifest V3 version effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important P0 Critical: Tackled by core team ASAP status/blocked Unable to be worked further until needs are met topic/ci Continuous integration
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants