Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Companion docs #1207

Closed
3 tasks done
Tracked by #1152
whizzzkid opened this issue May 19, 2023 · 5 comments · Fixed by #1230
Closed
3 tasks done
Tracked by #1152

Fix Companion docs #1207

whizzzkid opened this issue May 19, 2023 · 5 comments · Fixed by #1230
Assignees
Labels
area/MV3 Issues related to Manifest V3 version P3 Low: Not priority right now

Comments

@whizzzkid
Copy link
Contributor

whizzzkid commented May 19, 2023

Fix: https://docs.ipfs.tech/how-to/companion-node-types/#external

@whizzzkid whizzzkid added P3 Low: Not priority right now area/MV3 Issues related to Manifest V3 version labels May 19, 2023
@github-project-automation github-project-automation bot moved this to Needs Grooming in IPFS-GUI (PL EngRes) May 19, 2023
@BigLep
Copy link
Contributor

BigLep commented Jun 12, 2023

Remove Embedded till ready to be replaced via helia

This is tagged under "Fix companion docs" but this is bigger than docs right? We're also talking about removing code here. Your call, but this seems like its own issue providing some justification (linking to js-ipfs deprecation issue) with PR of code removal doc changes linked to it.

I think we should do this before we ship MV3.

@BigLep
Copy link
Contributor

BigLep commented Jun 12, 2023

Clarify External means kubo.

Instead of "Set to "External" to connect to a local node using the HTTP API." how about 'Set to "External" to connect to a local Kubo node using the Kubo RPC API."

Anytime we see "HTTP API" we should be fixing to disambiguate between the HTTP Gateway API and the Kubo RPC API.

@BigLep
Copy link
Contributor

BigLep commented Jun 12, 2023

Other things regarding "API" in the settings screen

API → Kubo RPC API

@whizzzkid whizzzkid self-assigned this Jun 15, 2023
@whizzzkid whizzzkid moved this from Needs Grooming to In Progress in IPFS-GUI (PL EngRes) Jun 15, 2023
@BigLep
Copy link
Contributor

BigLep commented Jul 12, 2023

@whizzzkid: I want to make sure you saw my comments that were added after merge: #1230 (review)

@whizzzkid
Copy link
Contributor Author

@BigLep yes, I'll create a follow up later tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/MV3 Issues related to Manifest V3 version P3 Low: Not priority right now
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants