Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom dialog for window.ipfs ACLs (make it work under Firefox) #377

Closed
lidel opened this issue Feb 8, 2018 · 2 comments · Fixed by #382
Closed

Custom dialog for window.ipfs ACLs (make it work under Firefox) #377

lidel opened this issue Feb 8, 2018 · 2 comments · Fixed by #382
Assignees
Labels
kind/bug A bug in existing code (including security flaws) topic/security Work related to security
Milestone

Comments

@lidel
Copy link
Member

lidel commented Feb 8, 2018

Gist from @alanshaw's TODO list in PR #333 (comment):

  • Add a custom confirm dialog. Firefox does not support window.confirm from the background process so it fails - all access to window.ipfs on Firefox will be automatically denied, however as a temporary workaround, Firefox users can use the manage permissions page to enable permissions after they have been auto denied
    • Another reason this is needed is that we want to be able to grant access to all (or a subset of) the API for a given origin, window.confirm can't cover these UX requirements

It may be useful to note how other extensions handle confirmation dialogs (repost from #333 (comment)):

I've noticed and found how Greasemonkey displays confirmation dialog (under Firefox):

https://github.com/greasemonkey/greasemonkey/blob/9ce5dabc74496fa6a631d991302ad4fd80730f1d/src/bg/user-script-detect.js#L76-L99

(HTML page loaded in new browser window with 'type': 'popup')

@lidel lidel added kind/bug A bug in existing code (including security flaws) UX labels Feb 8, 2018
@lidel lidel added this to the 2018-Q1 milestone Feb 8, 2018
@lidel lidel added the topic/security Work related to security label Feb 8, 2018
@lidel
Copy link
Member Author

lidel commented Feb 10, 2018

@alanshaw are you looking into this, or should I mark it as "up for grabs" ?

@alanshaw
Copy link
Member

I’m on it tomorrow morn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) topic/security Work related to security
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants