Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ipfs on PATH on windows with spaces in binary path #1465

Merged
merged 1 commit into from
Apr 28, 2020
Merged

fix: ipfs on PATH on windows with spaces in binary path #1465

merged 1 commit into from
Apr 28, 2020

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Apr 28, 2020

License: MIT
Signed-off-by: Henrique Dias [email protected]

@hacdias
fix: ipfs on path on windows with spaces in path
a344eb4 
License: MIT
Signed-off-by: Henrique Dias <[email protected]>
@hacdias hacdias requested a review from lidel April 28, 2020 19:36
@hacdias hacdias added area/windows Windows kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP labels Apr 28, 2020
lidel
lidel approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidel lidel merged commit f8e5ff3 into master Apr 28, 2020
@lidel lidel deleted the fix/ipfs-path-windows branch April 28, 2020 19:53
@lidel lidel mentioned this pull request Apr 28, 2020
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
area/windows Windows kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hacdias @lidel