Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] split or export functions that didn't export #28

Closed
bluelovers opened this issue Mar 24, 2020 · 5 comments
Closed

[request] split or export functions that didn't export #28

bluelovers opened this issue Mar 24, 2020 · 5 comments

Comments

@bluelovers
Copy link
Contributor

for example
https://github.com/ipfs/js-ipfs-utils/blob/master/src/files/normalise-input.js

export

  • toFileObject
  • toAsyncIterable
  • ... others

that will help if wanna reuse function for make something
because copy/paste code for just wanna re-use it , is not funny

@achingbrain
Copy link
Member

Most of these are pretty specific to normalising the input to file.add - do you have a specific use case in mind?

@bluelovers
Copy link
Contributor Author

because i have issue with this
ipfs/js-ipfs#2943

so i need make a new function for try avoid this happen

@achingbrain
Copy link
Member

I'm not sure I understand how this would help. Are you trying to reimplement bits of ipfs.add?

@bluelovers
Copy link
Contributor Author

yes

@achingbrain
Copy link
Member

In that case I'd just copy/paste the bits you need.

I don't think we should export or make available more than is necessary as it limits our ability to perform refactors or make other structural changes in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants