-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to switch over to using CIDv1 #3243
Comments
@kevina this is done, yeah? |
@whyrusleeping Depends on your definition of done. The merged p.r., #3743, only adds CidV1 support to the add command, other commands might need it and I also think it should be a global option not one local to add. |
@kevina fair enough, lets keep this one open. |
I am interested in helping with this. How can I get a list of command that might need this option ? |
This is a very involved issue that @kevina is currently working on. It looks deceptively simple but it's hard to do this without breaking things. I've updated the labels to indicate the current status. Sorry for the confusion. |
Yeah. My current things is we should do this via a config option. Switching to CIDV1 will break tones of stuff as we just expect a Cidv0 in many places, for example The switch to The switch to CIDv1 should come later. My thinking is provide a config and default it to CIDv1. This config option will effect most commands but not really low-level stuff so this should break less. This still needs a lot of thought though. |
To make it the switch over easier, lets get an option in as soon as possible to make go-ipfs use and generate version 1 CIDs for all internally created data. This will still be using the existing protobuf encoding for everything, the only difference will be that instead of a bare multihash (CIDv0) being used to address blocks and dags, we will use a full CID
The text was updated successfully, but these errors were encountered: