You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@whyrusleeping With the way you had me write the flag to select the CID version this should be easy to do. Do you want me to take this one it will probably only take me a few hours, including tests.
Setting the default to blake2b-256 would be an incompatible change so its best that it defaults to "sha2-256" for now.
Also CidV0 technically supports different hashes, but in practice this will cause decoding problems so this will only work with CidV1. The only question is should --hash=sha2-256 function also set the Cid version to 1. All other values will only work CidV1 so its best to just (unconditionally) set it.
I see this as step 1 towards enabling blake2b support. This flag could even default to blake2b-256
The text was updated successfully, but these errors were encountered: