Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when no peers and no boostrap peers configured #4576

Closed
dongtianyi opened this issue Jan 11, 2018 · 5 comments
Closed

Warn when no peers and no boostrap peers configured #4576

dongtianyi opened this issue Jan 11, 2018 · 5 comments
Labels
help wanted Seeking public contribution on this issue kind/feature A new feature

Comments

@dongtianyi
Copy link

dongtianyi commented Jan 11, 2018

Version information:

go-ipfs version: 0.4.13-
Repo version: 6
System version: amd64/darwin
Golang version: go1.9.2

Type:

Bug

Severity:

Description:

1 I use "ipfs bootstrap rm ..." to delete all the node"
2 run "ipfd daemon"
3 my ipfs node can not connect to network.

Yes, I know that I must use "ipfs bootstrap add []" to add myself bootstrap peer.
Actually, when I remove all the bootstrap nodes, I forget to set myself bootstrap peers.

It should give a warning when running "ipfs daemon".

@Stebalien
Copy link
Member

There are perfectly valid reasons to remove all bootstrap peers. For example, you want to remotely tell IPFS which peers to connect to or you want to add the bootstrap peers later.

Now, we could try to add something that detects this situation when you do something that requires peers. That is, when a command fails, run a simple function to try to diagnose what might have gone wrong and add that additional information to the error sent back to the user. However, we have to be careful here. Eventually, we'd like to expose parts of the API to semi-trusted applications (e.g., webapps) and we'd like to avoid exposing anything potentially sensitive).

Yes, I know that I must use "ipfs bootstrap add []" to add myself bootstrap peer.

You should never be adding yourself to the bootstrap peer list.

@Stebalien Stebalien added kind/feature A new feature help wanted Seeking public contribution on this issue labels Jan 11, 2018
@Stebalien Stebalien changed the title bootstrap issue Warn when no peers and no boostrap peers configured Jan 11, 2018
@ghost
Copy link

ghost commented Jan 11, 2018

It should give a warning when running "ipfs daemon".

I think that's a reasonable thing to add

@kjzz
Copy link
Contributor

kjzz commented Sep 8, 2018

Hey @Stebalien @lgierth , I am interested in this , can i help you do this?

@dtkav
Copy link
Contributor

dtkav commented Nov 5, 2018

I'm browsing through the help wanted tag and there are a lot of issues like this one that seem to be resolved.

Can this issue be closed?

@Stebalien
Copy link
Member

Yes. And please continue to point them out, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue kind/feature A new feature
Projects
None yet
Development

No branches or pull requests

4 participants