Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Can we get a new release soon and update js-ipld on js-ipfs? #116

Closed
daviddias opened this issue Feb 22, 2018 · 20 comments · Fixed by #117
Closed

Can we get a new release soon and update js-ipld on js-ipfs? #116

daviddias opened this issue Feb 22, 2018 · 20 comments · Fixed by #117
Assignees
@vmx

Comments

@daviddias
Copy link
Member

daviddias commented Feb 22, 2018 •
edited
Loading

Is this possible, @vmx? For the js-ipfs 0.28 release?
@daviddias daviddias mentioned this issue Feb 22, 2018
Closed
20 tasks
@vmx
Copy link
Member

vmx commented Feb 22, 2018

@diasdavid Feel free to do a release (or if you want, I can also do the release). It would be under the current name js-ipld-resolver. Let's target proper naming and description (#112) for the next release.

@daviddias
Copy link
Member Author

@vmx why not deprecate the old name and release with the new name?

@vmx
Copy link
Member

vmx commented Feb 22, 2018

@diasdavid: If we can sort out #112 that's fine for me.

@daviddias daviddias mentioned this issue Feb 26, 2018
Merged
@daviddias
Copy link
Member Author

@vmx I believe you have everything you need from #112 (comment)

@vmx
Copy link
Member

vmx commented Feb 26, 2018

@diasdavid So I should just change the package name name and publish a 0.28 under the new name?

@daviddias
Copy link
Member Author

@vmx exactly and then deprecate ipld-resolver with the message to use just ipld.

vmx added a commit that referenced this issue Feb 26, 2018
@vmx
chore: Rename package from ipld-resolver to ipld
85fcf24 
BREAKING CHANGE: All packages that depend on `ipld-resolver`
need to change their dependency.

Within your package that depends on `ipld-resolver` do:

    npm uninstall ipld-resolver
    npm intall ipld

Then search for all imports of `ipld-resolver` and change from

    const IPLDResolver = require('ipld-resolver')

to

    const Ipld = require('ipld')

Closes #116.
@vmx vmx mentioned this issue Feb 26, 2018
Merged
@vmx vmx self-assigned this Feb 26, 2018
@vmx vmx added the status/in-progress In progress label Feb 26, 2018
@daviddias
Copy link
Member Author

And of course, updating it in js-ipfs-unixfs-engine and js-ipfs too :)

@daviddias daviddias mentioned this issue Feb 26, 2018
Closed
@vmx
Copy link
Member

vmx commented Feb 26, 2018

I don't know if there's any guidelines for deprecation messages. What a about using this one:

WARNING: This project has been renamed to "ipld". Install using "ipld" instead.

@vmx vmx closed this as completed in #117 Feb 26, 2018
vmx added a commit that referenced this issue Feb 26, 2018
@vmx
chore: Rename package from ipld-resolver to ipld
8b82a49 
BREAKING CHANGE: All packages that depend on `ipld-resolver`
need to change their dependency.

Within your package that depends on `ipld-resolver` do:

    npm uninstall ipld-resolver
    npm intall ipld

Then search for all imports of `ipld-resolver` and change from

    const IPLDResolver = require('ipld-resolver')

to

    const Ipld = require('ipld')

Closes #116.
@vmx vmx removed the status/in-progress In progress label Feb 26, 2018
@vmx
Copy link
Member

vmx commented Feb 26, 2018

Sorry, I should've closed #93 and not this one. This one needs more work (and code changes on other packages).

@vmx vmx reopened this Feb 26, 2018
@vmx
Copy link
Member

vmx commented Feb 26, 2018

@diasdavid The js-ipfs-unixfs-engine update will take a bit as currently some tests fail: ipfs-inactive/js-ipfs-unixfs-engine#203

@daviddias
Copy link
Member Author

thanks @vmx, just incorporated your fixes, updated deps and released js-ipfs-unixfs-engine \o/

@vmx
Copy link
Member

vmx commented Feb 27, 2018

Almost there ipfs-inactive/js-ipfs-unixfs-engine#206

@vmx vmx reopened this Feb 27, 2018
@daviddias
Copy link
Member Author

got it. Confused with the refactor on js-ipfs which I also merged :) Thanks for being on top of things!

@vmx
Copy link
Member

vmx commented Feb 27, 2018

@diasdavid If you do another js-ipfs-unixfs-engine release, I think we are ready to go from an js-ipld perspective. One there's a new release of js-ipfs I'll deprecate js-ipld-resolver.

@vmx
Copy link
Member

vmx commented Feb 28, 2018

All packages that depended on ipld-resolver (https://github.com/ipfs/js-ipfs, https://github.com/ipfs/js-ipfs-unixfs-engine) switched to just "ipld". I will close this issue when I deprecated js-ipld-resolver, which I will do once https://github.com/ipfs/js-ipfs is releases. Else people will get deprecation messages during installation.

@vmx
Copy link
Member

vmx commented Mar 2, 2018

I can't deprecate ipld-resolver:

$ npm deprecate ipld-resolver@'<= 0.14.1' 'WARNING: This project has been renamed to "ipld". Install using "ipld" instead.'
npm ERR! code E422
npm ERR! Unprocessable Entity : ipld-resolver

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/vmx/.npm/_logs/2018-03-02T13_06_01_826Z-debug.log

@daviddias
Copy link
Member Author

@vmx have you reached out to npm support?

@vmx
Copy link
Member

vmx commented Mar 2, 2018

@diasdavid No I haven't, I thought I'm doing something wrong.

@daviddias
Copy link
Member Author

@vmx have you tried just with npm deprecate [email protected]?

@vmx
Copy link
Member

vmx commented Mar 2, 2018

@diasdavid Yes, also without version and putting the quotes around the name and version.

@daviddias daviddias added the status/ready Ready to be worked label Mar 19, 2018
@daviddias daviddias removed the status/ready Ready to be worked label Mar 21, 2018
@vmx vmx mentioned this issue Mar 26, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vmx vmx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Rename package from ipld-resolver to ipld ipld/js-ipld
2 participants
@vmx @daviddias