Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete TODOs or replace them with Issues #145

Closed
jackdewinter opened this issue Nov 20, 2021 · 12 comments
Closed

Complete TODOs or replace them with Issues #145

jackdewinter opened this issue Nov 20, 2021 · 12 comments
Labels
quality Task to improve the quality of the project.

Comments

@jackdewinter
Copy link
Owner

No description provided.

@jackdewinter jackdewinter added the quality Task to improve the quality of the project. label Nov 20, 2021
@jackdewinter
Copy link
Owner Author

jackdewinter commented Nov 20, 2021

Leaf Block Processor - __create_indented_block, after __prepare_for_indented_block (line 571)

need to revisit that code when proper tabs support added

Opened: #146

@jackdewinter
Copy link
Owner Author

Leaf Block Processor - # TODO why not use close?
switched to using close_open_blocks_fn

@jackdewinter
Copy link
Owner Author

jackdewinter commented Nov 20, 2021

Container Block Processor - __parse_line_for_leaf_blocks

# TODO rename to avoid collision with parameter
  • changed local to leaf_block_position_marker and incoming to position_marker

@jackdewinter
Copy link
Owner Author

Container Block Processor - __look_for_container_blocks

# TODO will need to deal with force_ignore_first_as_lrd
  • code is already asserting on requeue never being used
  • unless that changes, the TODO is meaningless, will deal with it then.

@jackdewinter
Copy link
Owner Author

Container Block Processor - __get_list_start_index

# TODO refactor so it doesn't need this!
  • the creation of a new position marker object isolates the main position marker from any changes
  • left as is

@jackdewinter
Copy link
Owner Author

Container Block Processor - __handle_leaf_tokens

# TODO refactor to make indent unnecessary?

@jackdewinter
Copy link
Owner Author

Block Quote Processor - __handle_block_quote_block_kludges

# TODO for nesting, may need to augment with this_bq_count already set.
  • think this is already being done with the alt_this_bq_count
  • removed TODO
  • cleaned up invocations of requeue_line_info and capture.

@jackdewinter
Copy link
Owner Author

main.py, main

# TODO self.__plugins.number_of_pragma_failures

@jackdewinter
Copy link
Owner Author

Transform To Gfm - __handle_end_fenced_code_block_token

# TODO can we store this in the begin so we don't have to compute it again?
  • not a clue what I was talking about, removed.

@jackdewinter
Copy link
Owner Author

__handle_link_reference_definition

# TODO - https://github.com/jackdewinter/pymarkdown/issues/100
  • already mentioned in issue 100

@jackdewinter
Copy link
Owner Author

Transform To Markdown - __perform_container_post_processing_lists

# TODO handle this better?
  • hard to figure out what it meant

@jackdewinter
Copy link
Owner Author

Transform To Markdown - __merge_with_container_data

# TODO can this be simplified like block quote?
  • not sure about block quote, but can work on simplifying the module itself.

jackdewinter added a commit that referenced this issue Nov 20, 2021
jackdewinter added a commit that referenced this issue Nov 20, 2021
jackdewinter added a commit that referenced this issue Nov 20, 2021
jackdewinter added a commit that referenced this issue Nov 21, 2021
jackdewinter added a commit that referenced this issue Nov 21, 2021
jackdewinter added a commit that referenced this issue Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Task to improve the quality of the project.
Projects
None yet
Development

No branches or pull requests

1 participant