-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#118 Add support for latest embedded-io #123
#118 Add support for latest embedded-io #123
Conversation
✅ Deploy Preview for cute-starship-2d9c9b canceled.
|
Thank you @elast0ny! I'm not 100% I want to use the pattern you did, of mutually exclusive features. I may want to instead offer both, in separate modules, with the existing See also #115 and #121. I'll want to be consistent with whatever I decide for the version bump. |
Thanks for the quick reply ! I needed support for v Let me know when you have a concrete path forward for this and I'll see if I can update my branch/PR ! Edit :
This would be nice but may lead to lots of duplicated impls (unless we write some macro-foo that swaps the trait bounds for each For example, you might need to copy paste the implementation of |
I'm going to merge this and then move it around a bit, thank you @elast0ny! |
No problem ! Just as an FYI, I've opened rust-embedded/embedded-hal#566 to see if we cant get a "stable" |
The way that `postcard` depends on 2 different versions of `embedded-io` (as of jamesmunns/postcard#123) apparently fools `cargo outdated`. Name Project Compat Latest Kind Platform ---- ------- ------ ------ ---- -------- postcard->embedded-io 0.6.1 0.4.0 0.4.0 Normal ---
The way that `postcard` depends on 2 different versions of `embedded-io` (as of jamesmunns/postcard#123) apparently fools `cargo outdated`. Name Project Compat Latest Kind Platform ---- ------- ------ ------ ---- -------- postcard->embedded-io 0.4.0 --- 0.6.1 Normal --- postcard->embedded-io 0.6.1 0.4.0 --- Normal ---
This adds a new
embedded-io-06
feature which allows users to use the latestembedded_io
v0.6.*
.Backwards compatibility is maintained with the previous
embedded-io
which is now setup to activate theembedded-io-04
feature internally.