-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of pretty-format #16
Conversation
Nice work! |
Hmm– testing with really large objects this is actually quite a bit slower. |
Never mind, I realized I've been doing something stupid and measuring this completely wrong. Here is the corrected comparison: https://gist.github.com/thejameskyle/f8b50bf559360549326b52f3bb323d5d |
Not sure I can trust you again after this. |
Hey I improved the performance without even having real metrics to guide me. That must count for something |
Okay, got everything working again and here are the new perf results: https://gist.github.com/thejameskyle/2b04ffe4941aafa8f970de077843a8fd |
I love it. Fantastic work, @thejameskyle. |
Woot! Heads up! There is some handy |
nice, thanks |
No prob. I've opened an issue on Node to propose exposing more of them ⚡ |
This doesn't support everything yet, but it is a pretty big restructuring that will allow it to work much much faster.
See comparison: https://gist.github.com/thejameskyle/fce69285d4682923061bf5f83461cc7b
cc @cpojer