-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task should not fail if xml report is not enabled #12
Comments
Hi @fabianMendez I thing that i had tried the part with the destination configuration but it didn't worked. Since I can't remember what the reason was i will give it a second go :-D having a hardcoded path is really bad taste. |
My problem was that the xml report is not enabled by default and the README does not mention that it should be enabled, so I had to search the error message in this repository which lead me to the conclusion that I had to enable it. Updating the readme should be enough 👍 |
I had an issue with composite builds, as the plugin was confused about where Another way of thinking would be to generate a warning and set the task output to I am happy to contribute to a solution! |
Since this plugin relies in the xml report being enabled for the jacoco plugin:
gradle-print-coverage-plugin/src/main/groovy/de/jansauer/printcoverage/PrintCoverageTask.groovy
Lines 25 to 29 in a121d16
It should not fail if this report is not enabled and maybe it could show a warning
Also, it could be better if the path of the report is taken from
jacocoTestReport.reports.xml.destination
The text was updated successfully, but these errors were encountered: