Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache-manager - adding disconnect to cache #899

Merged
merged 4 commits into from
Nov 17, 2024

Conversation

TimothyIp
Copy link
Contributor

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adds the ability to disconnect from the relevant stores inside the cache

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (921ebff) to head (679f1f7).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #899   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           67        67           
=========================================
  Hits            67        67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaredwray jaredwray self-assigned this Nov 17, 2024
@jaredwray jaredwray merged commit 2cdb224 into jaredwray:main Nov 17, 2024
3 checks passed
@jaredwray
Copy link
Owner

@TimothyIp - thanks so much and will get this rolled out in the next couple weeks.

@TimothyIp
Copy link
Contributor Author

This is awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants