Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to globally mask fields by name on all models. #702

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AMP999
Copy link

@AMP999 AMP999 commented Feb 21, 2025

Fixes #701

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.27%. Comparing base (5289482) to head (339ce70).
Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
auditlog/registry.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
+ Coverage   95.21%   95.27%   +0.05%     
==========================================
  Files          31       33       +2     
  Lines        1025     1101      +76     
==========================================
+ Hits          976     1049      +73     
- Misses         49       52       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hramezani
Copy link
Member

Thanks @AMP999 for this PR.

Please:

  • Add some tests
  • Add document for the new setting flag
  • Add changelog entry

@AMP999
Copy link
Author

AMP999 commented Feb 21, 2025

Thanks for the feedback, @hramezani !
I've added the requested changes, please let me know if any further refinements are needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to globally mask fields by name on all models.
2 participants