Add type hints for the resolver module #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atugushev
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1316 +/- ##
==========================================
+ Coverage 99.58% 99.62% +0.03%
==========================================
Files 33 33
Lines 2908 2921 +13
Branches 321 318 -3
==========================================
+ Hits 2896 2910 +14
+ Misses 6 5 -1
Partials 6 6
Continue to review full report at Codecov.
|
atugushev
commented
Feb 7, 2021
piptools/resolver.py
Outdated
| and self.specifier == other.specifier | ||
| and self.extras == other.extras | ||
| ) | ||
| return NotImplemented |
There was a problem hiding this comment.
FYI: this line left uncovered, so I've added it to exclude_lines to the coverage report config in a619d0d
webknjaz
reviewed
Feb 7, 2021
webknjaz
requested changes
Feb 7, 2021
jdufresne
reviewed
Feb 7, 2021
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Jon Dufresne <[email protected]>
Co-Authored-By: Jon Dufresne <[email protected]>
|
@jdufresne @webknjaz thanks for helping me with this PR! 🙏🏼 I've addressed all suggestions and I think it's ready for the second review round. |
webknjaz
reviewed
Feb 8, 2021
webknjaz
reviewed
Feb 8, 2021
webknjaz
reviewed
Feb 8, 2021
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
webknjaz
approved these changes
Feb 9, 2021
jdufresne
approved these changes
Feb 9, 2021
|
@jdufresne @webknjaz thanks for reviewing! 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #972
Additionally refactored
lookup_table():tests/test_utils.pyand add more tests