Enable mypy option no_implicit_reexport #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option is part of the set of "strict" mypy options, bringing the project closer to full strict checking. https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-reexport > By default, imported values to a module are treated as exported and > mypy allows other modules to import them. This flag changes the > behavior to not re-export unless the item is imported using from-as or > is included in `__all__`. A side benefit of using `__all__` is that it allows removing the flake8 exceptions from the code base. Now `__init__.py` files are checked too. Refs: #972
Codecov Report
@@ Coverage Diff @@
## master #1318 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 33 33
Lines 2907 2908 +1
Branches 321 321
=======================================
+ Hits 2895 2896 +1
Misses 6 6
Partials 6 6
Continue to review full report at Codecov.
|
atugushev
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is part of the set of "strict" mypy options, bringing the
project closer to full strict checking.
https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-reexport
A side benefit of using
__all__is that it allows removing the flake8exceptions from the code base. Now
__init__.pyfiles are checked too.Refs: #972