prints resources before deleting them instead of after #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jckuester
approved these changes
Jan 16, 2020
|
Hi @sonderops 👋 I am aware that this was an issue, so thank you for your fixing it! BTW, it seems many people like using |
|
No provlem @jckuester when doing a refactor consider the use case I have created in my other PR #64 as nuking certain resources that have been created without matching tags is definitely a use case we have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prints resources prior to deleting them
Before:
After:
I'm not a golang expert, there is likely a cleaner way of doing this.