Bug: Workspaces in Java 11 vs 8

[Immurb]

Workspaces created with JD+(Java 11) can't be opened with JD+(Java 8) and vice versa.

Error message:

java.io.IOException: Cannot probe workspace file format of 'WS_JavaX.xml'
	at ec.demetra.workspace.file.FileWorkspace.lambda$open$0(FileWorkspace.java:56)
	at java.base/java.util.Optional.orElseThrow(Optional.java:408)
	at ec.demetra.workspace.file.FileWorkspace.open(FileWorkspace.java:56)
[catch] at ec.nbdemetra.ws.FileRepository.load(FileRepository.java:194)...

The difference in the xml files seems to be the missing namespace in the Java 11 version. I attached my to test workspaces.
WS_Java8.zip
WS_Java11.zip

[charphi]

Thanks for finding this huge bug !

[charphi]

Same problem with Java 9 and 10.

The problem seems to come from the use of XmlSchema annotation in package-info.java files. This annotation defines the namespaces of the resulting xml.
This annotation is not processed at runtime by JD+ if running under Java9+.

Note that it works fine outside JD+.

[charphi]

After some digging, I have found that the problem is not related to JAXB.
The problem is due to the failed loading of any package-info.class contained in a NetBeans module under Java9+.

NetBeans module provides its own class loader: org.netbeans.SandardModule.OneModuleClassLoader.
This class loader overrides some methods. Unfortunatly, Java9+ introduces a new method ClassLoader#loadClass(Module, String) that is not known by NetBeans module and is called in Package#getPackageInfo(). The result is that not package info is loaded at all.

// jdk11
private Class<?> getPackageInfo() {
  if (packageInfo == null) {
    // find package-info.class defined by loader
    String cn = packageName() + ".package-info";
    Module module = module();
    PrivilegedAction<ClassLoader> pa = module::getClassLoader;
    ClassLoader loader = AccessController.doPrivileged(pa);
    Class<?> c;
    if (loader != null) {
      c = loader.loadClass(module, cn);
    } else {
      c = BootLoader.loadClass(module, cn);
    }

    if (c != null) {
      packageInfo = c;
    } else {
      // store a proxy for the package info that has no annotations
      class PackageInfoProxy {}
      packageInfo = PackageInfoProxy.class;
    }
  }
  return packageInfo;
}
  
// jdk8
private Class<?> getPackageInfo() {
  if (packageInfo == null) {
    try {
      packageInfo = Class.forName(pkgName + ".package-info", false, loader);
    } catch (ClassNotFoundException ex) {
      // store a proxy for the package info that has no annotations
      class PackageInfoProxy {}
      packageInfo = PackageInfoProxy.class;
    }
  }
  return packageInfo;
}

[charphi]

It is possible to force load package-info by using Class.forName(String).

[charphi]

Fixed by b8ad2a2