[FEATURE] add confirmationMessage for disable plugins and hide installButtons if minVersionJeedom is not compatible on market display repo #3013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sekiro-kost
changed the title
NebzHB
approved these changes
Jan 18, 2025
zoic21
approved these changes
Jan 21, 2025
Hotfirenet
approved these changes
Jan 24, 2025
Hotfirenet
assigned zoic21, Hotfirenet, tmartinez69009, Salvialf, Sekiro-kost and reineabs and unassigned zoic21, Hotfirenet, tmartinez69009, Salvialf, Sekiro-kost and reineabs
Mips2648
requested changes
Feb 19, 2025
install/update/reloadCache.php
Outdated
| @@ -34,7 +34,7 @@ | |||
| } | |||
| foreach ($data['eqLogic'] as $id => $value) { | |||
| $eqLogic = eqLogic::byId($id); | |||
| if(is_object($eqLogic)){ | |||
| if(is_object($cmd)){ | |||
There was a problem hiding this comment.
are you sure about this?
There was a problem hiding this comment.
In fact, there was indeed the basic error on the code.
I made a new PR from my fork, but my commit ended up on this PR which concerned the messages.
Since you had validated before, I wanted to go back to the original code
I made another PR in this sense:
#3032
Mips2648
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suggested changelog entry
Related issues/external references
Fixes #
Types of changes
PR checklist